n3nash commented on a change in pull request #3025: URL: https://github.com/apache/hudi/pull/3025#discussion_r651456965
########## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/BaseScheduleCompactionActionExecutor.java ########## @@ -63,7 +63,7 @@ public BaseScheduleCompactionActionExecutor(HoodieEngineContext context, + ", Compaction scheduled at " + instantTime)); // Committed and pending compaction instants should have strictly lower timestamps List<HoodieInstant> conflictingInstants = table.getActiveTimeline() - .getWriteTimeline().getInstants() + .getWriteTimeline().filterCompletedAndCompactionInstants().getInstants() Review comment: @danny0405 This class was NOT using `filterCompletedAndCompactionInstants` before. It was using `commitsAndCompactionTimeline()`. See this -> https://github.com/apache/hudi/blob/release-0.7.0/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/BaseScheduleCompactionActionExecutor.java#L65 Let me know if there is any confusion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org