danny0405 commented on a change in pull request #3025:
URL: https://github.com/apache/hudi/pull/3025#discussion_r651468804
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/BaseScheduleCompactionActionExecutor.java
##########
@@ -63,7 +63,7 @@ public
BaseScheduleCompactionActionExecutor(HoodieEngineContext context,
+ ", Compaction scheduled at " + instantTime));
// Committed and pending compaction instants should have strictly lower
timestamps
List<HoodieInstant> conflictingInstants = table.getActiveTimeline()
- .getWriteTimeline().getInstants()
+
.getWriteTimeline().filterCompletedAndCompactionInstants().getInstants()
Review comment:
Take a look at the comments
```java
// Committed and pending compaction instants should have strictly lower
timestamps
```
I think the code before that used `commitsAndCompactionTimeline()` is
already wrong, it add restrictions that we can not generate compaction plan
when there are inflight commits, of course we can actually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
