n3nash commented on a change in pull request #3025:
URL: https://github.com/apache/hudi/pull/3025#discussion_r651969762
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/BaseScheduleCompactionActionExecutor.java
##########
@@ -63,7 +63,7 @@ public
BaseScheduleCompactionActionExecutor(HoodieEngineContext context,
+ ", Compaction scheduled at " + instantTime));
// Committed and pending compaction instants should have strictly lower
timestamps
List<HoodieInstant> conflictingInstants = table.getActiveTimeline()
- .getWriteTimeline().getInstants()
+
.getWriteTimeline().filterCompletedAndCompactionInstants().getInstants()
Review comment:
Okay got it. So you're saying this bug was always there even in 0.7
release ? Can we please add a test case for this before landing ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
