chengxilo commented on code in PR #1916:
URL: https://github.com/apache/iggy/pull/1916#discussion_r2181550368
##########
foreign/go/binary_serialization/binary_response_deserializer.go:
##########
@@ -107,9 +94,9 @@ func DeserializeToStream(payload []byte, position int)
(StreamResponse, int) {
}, readBytes
}
Review Comment:
`DeserializeStream` deserialize the payload according to the position, to a
`StreamDetails`(has more attribute than Stream)
`DeserializeToStream` deserialize the payload to `Stream`, and return the
position after reading.
`DeserializeStreams` deserialize the payload to a `Stream` slice.
So basically `DeserializeToStream` is used as the tool for
`DeserializeStream` and `DeserializeStreams`. You will see a lot of function
like this in the serialization layor. I moidfy my code according to this
pattern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
