chengxilo commented on code in PR #1916:
URL: https://github.com/apache/iggy/pull/1916#discussion_r2181574775
##########
foreign/go/binary_serialization/binary_response_deserializer.go:
##########
@@ -28,27 +28,36 @@ import (
"github.com/klauspost/compress/s2"
)
-func DeserializeLogInResponse(payload []byte) *LogInResponse {
+func DeserializeLogInResponse(payload []byte) *IdentityInfo {
userId := binary.LittleEndian.Uint32(payload[0:4])
- return &LogInResponse{
+ return &IdentityInfo{
UserId: userId,
}
}
-func DeserializeOffset(payload []byte) *OffsetResponse {
+func DeserializeOffset(payload []byte) *ConsumerOffsetInfo {
partitionId := int(binary.LittleEndian.Uint32(payload[0:4]))
currentOffset := binary.LittleEndian.Uint64(payload[4:12])
storedOffset := binary.LittleEndian.Uint64(payload[12:20])
- return &OffsetResponse{
+ return &ConsumerOffsetInfo{
PartitionId: partitionId,
CurrentOffset: currentOffset,
StoredOffset: storedOffset,
}
}
-func DeserializeStreams(payload []byte) []StreamResponse {
- streams := make([]StreamResponse, 0)
+func DeserializeStream(payload []byte) *StreamDetails {
+ stream, _ := DeserializeToStream(payload, 0)
+ // TODO implement deserialize topics
Review Comment:
I add TODO here, as the StreamDetails need a topic slice. Since this pr is
not aimed to solve all of problems like this. We can do this in the future.
I added a few TODOs like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
