haze518 commented on code in PR #1916:
URL: https://github.com/apache/iggy/pull/1916#discussion_r2183975044
##########
foreign/go/binary_serialization/log_in_request_serializer.go:
##########
@@ -19,19 +19,18 @@ package binaryserialization
import (
"encoding/binary"
-
- iggcon "github.com/apache/iggy/foreign/go/contracts"
)
type TcpLogInRequest struct {
- iggcon.LogInRequest
+ Username string `json:"username"`
+ Password string `json:"password"`
}
func (request *TcpLogInRequest) Serialize() []byte {
usernameBytes := []byte(request.Username)
passwordBytes := []byte(request.Password)
- versionBytes := []byte(request.Version)
- contextBytes := []byte(request.Context)
+ versionBytes := []byte("")
+ contextBytes := []byte("")
Review Comment:
yeah, actually, first of all it looks like this is legacy, and secondly,
there isn’t really an equivalent in Go—unless you inject the version via
ldflags (which might be overkill), or just use the tag number
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
