chengxilo commented on code in PR #1916:
URL: https://github.com/apache/iggy/pull/1916#discussion_r2181588140
##########
foreign/go/binary_serialization/log_in_request_serializer.go:
##########
@@ -19,19 +19,18 @@ package binaryserialization
import (
"encoding/binary"
-
- iggcon "github.com/apache/iggy/foreign/go/contracts"
)
type TcpLogInRequest struct {
- iggcon.LogInRequest
+ Username string `json:"username"`
+ Password string `json:"password"`
}
func (request *TcpLogInRequest) Serialize() []byte {
usernameBytes := []byte(request.Username)
passwordBytes := []byte(request.Password)
- versionBytes := []byte(request.Version)
- contextBytes := []byte(request.Context)
+ versionBytes := []byte("")
+ contextBytes := []byte("")
Review Comment:
I use "", "" to replace them, currently it would have the same behavior as
the previous golang sdk. In rust sdk, they will read the cargo pkg version. I
think it doesn't work for go, and I am not sure whether it is some historical
code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
