chengxilo commented on code in PR #1916:
URL: https://github.com/apache/iggy/pull/1916#discussion_r2181603571
##########
foreign/go/tcp/tcp_user_managament.go:
##########
@@ -36,7 +36,7 @@ func (tms *IggyTcpClient) GetUser(identifier Identifier)
(*UserResponse, error)
return binaryserialization.DeserializeUser(buffer)
}
-func (tms *IggyTcpClient) GetUsers() ([]*UserResponse, error) {
+func (tms *IggyTcpClient) GetUsers() ([]UserInfo, error) {
Review Comment:
In this update, I changed []*UserResponse to []iggcon.UserInfo. Although
both are slices, the new version uses value elements instead of pointers. I
made this change because UserInfo is relatively lightweight, and for
consistency—all other functions returning slices use values rather than
pointers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
