fantonangeli commented on PR #2853: URL: https://github.com/apache/incubator-kie-tools/pull/2853#issuecomment-2618800670
@jomarko Thanks a lot for your review. Regarding the tests for `dev-deployment-dmn-form-webapp`, is it enough to test with this command only? `pnpm -F dev-deployment-dmn-form-webapp start` then open: http://localhost:9008/ > I will stop my review here. I think I tested quite well 2 of three componenets I was asked: > > * `online-editor` âī¸ > > * `dmn-editor` âī¸ > > * `dev-deployment-dmn-form-webapp` đĢ > > > I think I could test also `runtime-tools-process-dev-ui-webapp` however will do maybe in secound round of review. > ### dev-deployment-dmn-form-webapp > > The problem I have for testing `dev-deployment-dmn-form-webapp` is I never used it as standalone and locally > > I made this build: > > * `KIE_TOOLS_BUILD__buildContainerImages=true pnpm -F @kie-tools/dev-deployment-kogito-quarkus-blank-app-image... build:prod` > > * `KIE_TOOLS_BUILD__buildContainerImages=true pnpm -F @kie-tools/dev-deployment-dmn-form-webapp-image... build:prod` > > > Then started: > > * `docker run -p 8080:8080 -e DEV_DEPLOYMENT__UPLOAD_SERVICE_API_KEY=dev docker.io/apache/incubator-kie-sandbox-dev-deployment-kogito-quarkus-blank-app:main` > > * `docker run -d -p 8081:8081 -e DEV_DEPLOYMENT_DMN_FORM_WEBAPP_QUARKUS_APP_ORIGIN=http://localhost:8080 docker.io/apache/incubator-kie-sandbox-dev-deployment-dmn-form-webapp:main` > > > And tried to deploy DMN as: > > * `curl -X POST -H "Content-Type: multipart/form-data" -F "myFile=/home/jomarko/kie-tools/examples/process-compact-architecture/src/main/resources/assets.zip" 'http://localhost:8080/upload?apiKey=dev'` > > > However always get some error, I need more guidance how to deploy some dmn on the running images. > > ``` > [dev-deployment-upload-service] âšī¸ Upload arrived... > [dev-deployment-upload-service] â ERROR: Reading uploaded file failed: > [dev-deployment-upload-service] â ERROR: http: no such file > 2025/01/20 15:53:33 http: panic serving 172.17.0.1:50788: runtime error: invalid memory address or nil pointer dereference > goroutine 49 [running]: > net/http.(*conn).serve.func1() > /nix/store/frc5188kgv3ws0n999c7cy5vi2f8k4jp-go-1.22.9/share/go/src/net/http/server.go:1903 +0xbe > panic({0x667c00?, 0x8c0d60?}) > /nix/store/frc5188kgv3ws0n999c7cy5vi2f8k4jp-go-1.22.9/share/go/src/runtime/panic.go:770 +0x132 > main.main.func3({0x727320, 0xc0002ba000}, 0xc0002ac000) > /home/jomarko/kie-tools/packages/dev-deployment-upload-service/main.go:169 +0x7d5 > net/http.HandlerFunc.ServeHTTP(0x8cce50?, {0x727320?, 0xc0002ba000?}, 0x10?) > /nix/store/frc5188kgv3ws0n999c7cy5vi2f8k4jp-go-1.22.9/share/go/src/net/http/server.go:2171 +0x29 > net/http.(*ServeMux).ServeHTTP(0x40e745?, {0x727320, 0xc0002ba000}, 0xc0002ac000) > /nix/store/frc5188kgv3ws0n999c7cy5vi2f8k4jp-go-1.22.9/share/go/src/net/http/server.go:2688 +0x1ad > net/http.serverHandler.ServeHTTP({0x7266a0?}, {0x727320?, 0xc0002ba000?}, 0x6?) > /nix/store/frc5188kgv3ws0n999c7cy5vi2f8k4jp-go-1.22.9/share/go/src/net/http/server.go:3142 +0x8e > net/http.(*conn).serve(0xc000296000, {0x727840, 0xc000200210}) > /nix/store/frc5188kgv3ws0n999c7cy5vi2f8k4jp-go-1.22.9/share/go/src/net/http/server.go:2044 +0x5e8 > created by net/http.(*Server).Serve in goroutine 19 > /nix/store/frc5188kgv3ws0n999c7cy5vi2f8k4jp-go-1.22.9/share/go/src/net/http/server.go:3290 +0x4b4 > [dev-deployment-upload-service] â ī¸ Upload arrived, but another arrived earlier. Server should be in the process of gracefully shutting down. > ``` > > Please let me know once the PR is ready for my another review round. Once more, thank you for this huge effort! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
