fantonangeli commented on code in PR #2853:
URL:
https://github.com/apache/incubator-kie-tools/pull/2853#discussion_r1958060604
##########
packages/boxed-expression-component/src/expressions/FunctionExpression/JavaFunctionExpression.tsx:
##########
@@ -467,7 +468,9 @@ function JavaFunctionExpressionLabelCell(props:
React.PropsWithChildren<BeeTable
headerContent={label + " example"}
bodyContent={getParameterLabelHelp}
>
- <HelpIcon size="sm" className="java-function-parameter-help-icon"
/>
+ <Icon size="sm" style={{ marginLeft: "10px", marginTop: "5px" }}>
Review Comment:
Can we modify the CSS class already created instead of using the style
property?
https://github.com/kumaradityaraj/kie-tools/blob/5b709227e7f140157157c3e3a45ceaf6f258af65/packages/boxed-expression-component/src/expressions/FunctionExpression/JavaFunctionExpression.css#L49
##########
packages/online-editor/src/accounts/AccountsIcon.tsx:
##########
@@ -181,22 +187,24 @@ export function AccountsIcon() {
</div>
}
>
- <Page>
- <PageSection variant={"light"}>
- <>
- {accounts.section === AccountsSection.HOME && (
- <>
- {authSessions.size <= 0 && (
- <Bullseye>
- <EmptyState style={{ maxWidth: "400px" }}>
- <EmptyStateIcon icon={UsersIcon} />
- <Title headingLevel="h4" size="md">
- {`Looks like you don't have any accounts connected
yet`}
- </Title>
- <br />
- <br />
+ {/* <Page> */}
Review Comment:
I think we should fix some UI differences in this component and possibly
uncomment this line, as also described in comment `#1` :
https://github.com/apache/incubator-kie-tools/pull/2853#issuecomment-2602139511
##########
packages/online-editor/src/authProviders/AuthProviderIcon.tsx:
##########
@@ -27,36 +26,26 @@ import QuestionIcon from
"@patternfly/react-icons/dist/js/icons/question-icon";
import UsersIcon from "@patternfly/react-icons/dist/js/icons/users-icon";
import { AuthProvider } from "./AuthProvidersApi";
-export function AuthProviderIcon(props: {
- authProvider: AuthProvider | undefined;
- size: IconSize | keyof typeof IconSize;
Review Comment:
Before `AuthProviderIcon` was accepting a props for the size here.
We can use that property like it was before and pass the size to the `Icon`
tag inside AuthProviderIcon so who call it can decide the size.
##########
packages/sonataflow-deployment-webapp/src/pages/BasePage.tsx:
##########
@@ -109,7 +112,17 @@ export function BasePage(props: { children?:
React.ReactNode }) {
}, [history, app.appDataPromise]);
return (
- <Page sidebar={<PageSidebar nav={<BasePageNav />} theme="dark" />}
header={masthead} isManagedSidebar>
+ <Page
+ sidebar={
+ <PageSidebar theme="dark">
+ {/* <PageSidebarBody> */}
Review Comment:
I think we can remove these commented lines
##########
packages/online-editor/src/authProviders/AuthProviderIcon.tsx:
##########
@@ -27,36 +26,26 @@ import QuestionIcon from
"@patternfly/react-icons/dist/js/icons/question-icon";
import UsersIcon from "@patternfly/react-icons/dist/js/icons/users-icon";
import { AuthProvider } from "./AuthProvidersApi";
-export function AuthProviderIcon(props: {
- authProvider: AuthProvider | undefined;
- size: IconSize | keyof typeof IconSize;
-}) {
+export function AuthProviderIcon(props: { authProvider: AuthProvider |
undefined }) {
if (!props.authProvider) {
- return <UsersIcon size={props.size} />;
- }
-
- if (props.authProvider.iconPath) {
Review Comment:
Following my previous comment we can bring back this portion of code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
