fantonangeli commented on code in PR #2853:
URL:
https://github.com/apache/incubator-kie-tools/pull/2853#discussion_r1943369420
##########
packages/scesim-editor/src/TestScenarioEditor.tsx:
##########
@@ -86,19 +91,30 @@ enum TestScenarioFileStatus {
/* Types */
+// export type TestScenarioAlert = {
Review Comment:
There is some commented code in this file which was not here before, can you
please remove them?
##########
packages/sonataflow-deployment-webapp/src/runtimeTools/pages/RuntimeToolsWorkflowInstances.tsx:
##########
@@ -43,10 +48,20 @@ export function RuntimeToolsWorkflowInstances() {
<PageSection variant="light">
<Bullseye>
<EmptyState>
- <EmptyStateIcon icon={CubesIcon} />
- <Title headingLevel="h4" size="lg">
- {`Data Index service not available`}
- </Title>
+ {/* <EmptyStateHeader
+ titleText={<>{`Data Index service not available`}</>}
+ icon={<EmptyStateIcon icon={CubesIcon} />}
+ headingLevel="h4"
+ /> */}
Review Comment:
```suggestion
```
##########
packages/dashbuilder-component-victory-charts/src/charts/DonutChart.tsx:
##########
@@ -40,7 +40,6 @@ export class DonutChart extends PieBaseChart {
subTitle={this.props.donutSubTitle || ""}
title={this.props.donutTitle || ""}
themeColor={themeColor}
- themeVariant={themeVariant}
Review Comment:
`themeVariant` prop has been removed and the variant is received globally
from the HTML tag.
I would remove all references to `themeVariant` in
`dashbuilder-component-victory-charts` if they are not used anymore.
Ref: https://github.com/patternfly/patternfly-react/pull/8590
##########
packages/sonataflow-deployment-webapp/src/pages/BasePage.tsx:
##########
@@ -73,11 +75,13 @@ export function BasePage(props: { children?:
React.ReactNode }) {
<Toolbar id="toolbar" isFullHeight isStatic>
<ToolbarContent>
{app.data.showDisclaimer && (
- <ToolbarItem alignment={{ default: "alignRight" }}>
+ // <ToolbarItem align={{ default: "alignRight" }}>
Review Comment:
```suggestion
```
##########
packages/yard-editor/dev-webapp/EmptyState.tsx:
##########
@@ -24,9 +24,10 @@ import {
EmptyState,
EmptyStateBody,
EmptyStateIcon,
- EmptyStateSecondaryActions,
+ EmptyStateActions,
+ // EmptyStateSecondaryActions,
Review Comment:
```suggestion
```
##########
packages/patternfly-base/index.js:
##########
@@ -54,7 +54,6 @@ const fontsRule = {
// Limit at 50k. larger files emitted into separate files
limit: 5000,
outputPath: "fonts",
- name: "[name].[ext]",
Review Comment:
Can we bring back the line:
`name: "[name].[ext]",`
GH Web cannot make suggestions on deleted lines
##########
packages/sonataflow-management-console-webapp/src/components/pages/BasePage.tsx:
##########
@@ -63,12 +64,18 @@ export function BasePage(props: { children?:
React.ReactNode }) {
</MastheadContent>
</Masthead>
),
- []
+ [history]
);
return (
<Page
- sidebar={<PageSidebar nav={<ManagementConsoleNav
pathname={history.location.pathname} />} theme="dark" />}
+ sidebar={
+ <PageSidebar theme="dark">
+ {/* <PageSidebarBody> */}
+ <ManagementConsoleNav pathname={history.location.pathname} />
+ {/* </PageSidebarBody> */}
+ </PageSidebar>
Review Comment:
```suggestion
<PageSidebar theme="dark">
<ManagementConsoleNav pathname={history.location.pathname} />
</PageSidebar>
```
##########
packages/stunner-editors/kie-wb-common-dmn/kie-wb-common-dmn-webapp-kogito-runtime/src/test/java/org/kie/workbench/common/dmn/showcase/client/selenium/locator/EditorXPathLocator.java:
##########
@@ -43,7 +43,8 @@ public static EditorXPathLocator
expressionAutocompleteEditor() {
* @return XPath Locator for currently opened expression title
*/
public static EditorXPathLocator expressionEditorTitle() {
- return new EditorXPathLocator("//p[@class='expression-info-name
pf-u-text-truncate name']");
+ // return new EditorXPathLocator("//p[@class='expression-info-name
pf-u-text-truncate name']");
+ return new EditorXPathLocator("//p[@class='expression-info-name
pf-v5-u-text-truncate name']");
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
