fantonangeli commented on code in PR #2853:
URL:
https://github.com/apache/incubator-kie-tools/pull/2853#discussion_r2003776336
##########
packages/serverless-logic-web-tools/src/homepage/overView/CreateOrImportModelGrid.tsx:
##########
@@ -41,11 +41,13 @@ export function CreateOrImportModelGrid(props: { isNavOpen:
boolean }) {
<GridItem xl={12} xl2={force12Cols ? 12 : 6}>
<Card className="Dev-ui__card-size" style={{ height: "100%" }}>
<CardHeader>
- <CardHeaderMain>
- <CardTitle>
- <Title headingLevel="h2">Create</Title>
- </CardTitle>
- </CardHeaderMain>
+ {
+ <>
+ <CardTitle>
+ <Title headingLevel="h2">Create</Title>
+ </CardTitle>
+ </>
+ }
Review Comment:
```suggestion
<CardTitle>
<Title headingLevel="h2">Create</Title>
</CardTitle>
```
##########
packages/runtime-tools-swf-enveloped-components/src/cloudEventForm/envelope/components/CloudEventForm/CloudEventForm.tsx:
##########
@@ -229,9 +244,24 @@ export const CloudEventForm: React.FC<CloudEventFormProps
& OUIAProps> = ({
isRequired
type="text"
id="eventType"
- onChange={setEventType}
+ onChange={(_event, val) => setEventType(val)}
validated={getValidatedOption("eventType")}
/>
+ {getValidatedOption("eventType") === "error" ? (
+ <FormHelperText>
+ <HelperText>
+ <HelperTextItem variant="warning" icon={<ExclamationCircleIcon
color="#c9190b" />}>
Review Comment:
```suggestion
<HelperTextItem variant="error" icon={<ExclamationCircleIcon
color="#c9190b" />}>
```
##########
packages/runtime-tools-swf-enveloped-components/src/cloudEventForm/envelope/components/CloudEventForm/CloudEventForm.tsx:
##########
@@ -185,37 +184,53 @@ export const CloudEventForm: React.FC<CloudEventFormProps
& OUIAProps> = ({
}
>
<InputGroup>
- <Select
- id={"method"}
- width={"100px"}
- variant={SelectVariant.single}
- selections={method}
- onSelect={(event, value: "POST" | "PUT") => {
- setMethod(CloudEventMethod[value] ?? CloudEventMethod.POST);
- setIsMethodOpen(false);
- }}
- isOpen={isMethodOpen}
- onToggle={() => setIsMethodOpen(!isMethodOpen)}
- >
- <SelectOption value={CloudEventMethod.POST} />
- <SelectOption value={CloudEventMethod.PUT} />
- </Select>
- <TextInput
- id={"endpoint"}
- isRequired
- value={endpoint}
- onChange={setEndpoint}
- validated={getValidatedOption("endpoint")}
- />
+ <InputGroupItem>
+ <Select
+ id={"method"}
+ width={"100px"}
+ variant={SelectVariant.single}
+ selections={method}
+ onSelect={(event, value: "POST" | "PUT") => {
+ setMethod(CloudEventMethod[value] ?? CloudEventMethod.POST);
+ setIsMethodOpen(false);
+ }}
+ isOpen={isMethodOpen}
+ onToggle={() => setIsMethodOpen(!isMethodOpen)}
+ >
+ <SelectOption value={CloudEventMethod.POST} />
+ <SelectOption value={CloudEventMethod.PUT} />
+ </Select>
+ </InputGroupItem>
+ <InputGroupItem isFill>
+ <TextInput
+ id={"endpoint"}
+ isRequired
+ value={endpoint}
+ onChange={(_event, val) => setEndpoint(val)}
+ validated={getValidatedOption("endpoint")}
+ />
+ </InputGroupItem>
</InputGroup>
+ {getValidatedOption("endpoint") === "error" ? (
+ <FormHelperText>
+ <HelperText>
+ <HelperTextItem variant="warning" icon={<ExclamationCircleIcon
color="#c9190b" />}>
Review Comment:
```suggestion
<HelperTextItem variant="error" icon={<ExclamationCircleIcon
color="#c9190b" />}>
```
##########
packages/pmml-editor/src/editor/components/Outputs/organisms/OutputFieldExtendedProperties.tsx:
##########
@@ -196,39 +201,59 @@ export const OutputFieldExtendedProperties = (props:
OutputFieldExtendedProperti
<FormSelectOption value={option} key={index} label={option} />
))}
</FormSelect>
+ {validationsTargetField.length === 0 ? (
+ <FormHelperText>
+ <HelperText>
+ <HelperTextItem variant="default"></HelperTextItem>
+ </HelperText>
+ </FormHelperText>
+ ) : (
+ <FormHelperText>
+ <HelperText>
+ <HelperTextItem
variant="warning">{validationsTargetField[0].message}</HelperTextItem>
+ </HelperText>
+ </FormHelperText>
+ )}
</FormGroup>
<FormGroup
label="Feature"
fieldId="output-feature-helper"
- helperText="Specifies the value the output field takes from the
computed mining result."
+ // helperText="Specifies the value the output field takes from the
computed mining result."
Review Comment:
@kumaradityaraj Can you please check this?
##########
packages/runtime-tools-swf-enveloped-components/src/cloudEventForm/envelope/components/CloudEventForm/CloudEventForm.tsx:
##########
@@ -311,6 +355,21 @@ export const CloudEventForm: React.FC<CloudEventFormProps
& OUIAProps> = ({
}
>
{requestDataEditor}
+ {getValidatedOption("eventData") === "error" ? (
+ <FormHelperText>
+ <HelperText>
+ <HelperTextItem variant="warning" icon={<ExclamationCircleIcon
color="#c9190b" />}>
Review Comment:
```suggestion
<HelperTextItem variant="error" icon={<ExclamationCircleIcon
color="#c9190b" />}>
```
##########
packages/serverless-logic-web-tools/src/homepage/overView/CreateOrImportModelGrid.tsx:
##########
@@ -72,11 +74,13 @@ export function CreateOrImportModelGrid(props: { isNavOpen:
boolean }) {
<GridItem xl={12} xl2={force12Cols ? 12 : 6}>
<Card className="Dev-ui__card-size" style={{ height: "100%" }}>
<CardHeader>
- <CardHeaderMain>
- <CardTitle>
- <Title headingLevel="h2">Import</Title>
- </CardTitle>
- </CardHeaderMain>
+ {
+ <>
+ <CardTitle>
+ <Title headingLevel="h2">Import</Title>
+ </CardTitle>
+ </>
+ }
Review Comment:
```suggestion
<CardTitle>
<Title headingLevel="h2">Import</Title>
</CardTitle>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
