fantonangeli commented on code in PR #2853:
URL:
https://github.com/apache/incubator-kie-tools/pull/2853#discussion_r1991212155
##########
packages/online-editor/src/authSessions/AuthSessionLabel.tsx:
##########
@@ -23,15 +23,15 @@ import { AuthSession } from "./AuthSessionApi";
import { useAuthProvider } from "../authProviders/AuthProvidersContext";
import { AuthProviderIcon } from "../authProviders/AuthProviderIcon";
import { Flex } from "@patternfly/react-core/dist/js/layouts/Flex";
-import { IconSize } from "@patternfly/react-icons/dist/js/createIcon";
+import { Icon } from "@patternfly/react-core/dist/js/components/Icon";
Review Comment:
```suggestion
```
##########
packages/online-editor/src/accounts/AccountsIcon.tsx:
##########
@@ -158,7 +163,7 @@ export function AccountsIcon() {
</TextContent>
</Flex>
</FlexItem>
- <AuthProviderIcon
authProvider={accounts.selectedAuthProvider} size={"sm"} />
+ <AuthProviderIcon
authProvider={accounts.selectedAuthProvider} />
Review Comment:
```suggestion
<AuthProviderIcon
authProvider={accounts.selectedAuthProvider} size={"sm"} />
```
##########
packages/online-editor/src/authProviders/AuthProvidersGallery.tsx:
##########
@@ -126,26 +127,30 @@ export function AuthProvidersGallery(props: {
}}
>
<CardHeader>
- <CardHeaderMain>
- <CardTitle>{authProvider.name}</CardTitle>
- <TextContent>
- {(!authProvider.enabled && (
- <TextContent>
+ {
+ <>
+ <CardTitle>{authProvider.name}</CardTitle>
+ <TextContent>
+ {(!authProvider.enabled && (
+ <TextContent>
+ <Text component={TextVariants.small}>
+ <i>Available soon!</i>
+ </Text>
+ </TextContent>
+ )) || (
<Text component={TextVariants.small}>
- <i>Available soon!</i>
+ <i>{authProvider.domain ?? <> </>}</i>
</Text>
- </TextContent>
- )) || (
- <Text component={TextVariants.small}>
- <i>{authProvider.domain ?? <> </>}</i>
- </Text>
- )}
- </TextContent>
- </CardHeaderMain>
+ )}
+ </TextContent>
+ </>
+ }
</CardHeader>
<br />
<CardBody>
- <AuthProviderIcon authProvider={authProvider}
size={"xl"} />
+ {/* <Icon size={"xl"}> */}
+ <AuthProviderIcon authProvider={authProvider} size="xl"
/>
+ {/* </Icon> */}
Review Comment:
```suggestion
<AuthProviderIcon authProvider={authProvider}
size="xl" />
```
##########
packages/online-editor/src/editor/Toolbar/GitIntegration/CreateGitRepositoryModal.tsx:
##########
@@ -25,7 +25,7 @@ import { useWorkspaces } from
"@kie-tools-core/workspaces-git-fs/dist/context/Wo
import { Form, FormAlert, FormGroup, FormHelperText } from
"@patternfly/react-core/dist/js/components/Form";
import { Radio } from "@patternfly/react-core/dist/js/components/Radio";
import { TextInput } from
"@patternfly/react-core/dist/js/components/TextInput";
-import { CheckCircleIcon } from
"@patternfly/react-icons/dist/js/icons/check-circle-icon";
+
Review Comment:
Can we reintroduce the use of `CheckCircleIcon` and `ExclamationCircleIcon`?
##########
packages/online-editor/src/authSessions/AuthSessionSelect.tsx:
##########
@@ -43,6 +43,7 @@ import { Text, TextContent, TextVariants } from
"@patternfly/react-core/dist/js/
import { AuthSession, AuthSessionStatus, AUTH_SESSION_NONE } from
"./AuthSessionApi";
import { v4 as uuid } from "uuid";
import { useAuthProviders } from "../authProviders/AuthProvidersContext";
+import { Icon } from "@patternfly/react-core/dist/js/components/Icon";
Review Comment:
```suggestion
```
##########
packages/online-editor/src/settings/ExtendedServicesSettingsTab.tsx:
##########
@@ -73,43 +75,61 @@ export function ExtendedServicesSettingsTab() {
</FormAlert>
<FormGroup
isRequired={true}
- helperTextInvalid={""}
- validated={"default"}
+ // helperTextInvalid={""}
+ // validated={"default"}
label={"Host"}
fieldId={"host-input"}
>
<InputGroup>
- <TextInput
- id="host-input"
- name="host"
- aria-describedby="host-text-input-helper"
- placeholder={""}
- validated={"default"}
- value={host}
- onChange={setHost}
- autoFocus={true}
- />
+ <InputGroupItem isFill>
+ <TextInput
+ id="host-input"
+ name="host"
+ aria-describedby="host-text-input-helper"
+ placeholder={""}
+ validated={"default"}
+ value={host}
+ onChange={(_event, val) => setHost(val)}
+ autoFocus={true}
+ />
+ </InputGroupItem>
</InputGroup>
+ <HelperText>
+ {/* (
+ <HelperTextItem variant="default"
icon={ValidatedOptions.default}>
+ {""}
+ </HelperTextItem>
+ ) */}
+ </HelperText>
</FormGroup>
<FormGroup
isRequired={false}
- helperTextInvalid={""}
- validated={"default"}
+ // helperTextInvalid={""}
+ // validated={"default"}
Review Comment:
```suggestion
```
##########
packages/online-editor/src/settings/ExtendedServicesSettingsTab.tsx:
##########
@@ -20,14 +20,16 @@
import * as React from "react";
import { useCallback, useState } from "react";
import { ActionGroup, Form, FormAlert, FormGroup } from
"@patternfly/react-core/dist/js/components/Form";
-import { InputGroup } from
"@patternfly/react-core/dist/js/components/InputGroup";
+import { InputGroup, InputGroupItem } from
"@patternfly/react-core/dist/js/components/InputGroup";
import { TextInput } from
"@patternfly/react-core/dist/js/components/TextInput";
import { Page, PageSection } from
"@patternfly/react-core/dist/js/components/Page";
import { useSettings, useSettingsDispatch } from "./SettingsContext";
import { Button } from "@patternfly/react-core/dist/js/components/Button";
import { Alert } from "@patternfly/react-core/dist/js/components/Alert";
import { useExtendedServices } from
"../extendedServices/ExtendedServicesContext";
import { ExtendedServicesStatus } from
"../extendedServices/ExtendedServicesStatus";
+import { HelperText, HelperTextItem } from
"@patternfly/react-core/dist/js/components/HelperText";
+import { ValidatedOptions } from "@patternfly/react-core/dist/js/helpers";
Review Comment:
```suggestion
import { HelperText } from
"@patternfly/react-core/dist/js/components/HelperText";
```
##########
packages/online-editor/src/accounts/AccountsIcon.tsx:
##########
@@ -132,7 +137,7 @@ export function AccountsIcon() {
</TextContent>
</Flex>
</FlexItem>
- <AuthProviderIcon
authProvider={accounts.selectedAuthProvider} size={"sm"} />
+ <AuthProviderIcon
authProvider={accounts.selectedAuthProvider} />
Review Comment:
```suggestion
<AuthProviderIcon
authProvider={accounts.selectedAuthProvider} size={"sm"} />
```
##########
packages/pmml-editor/src/editor/components/DataDictionary/MultipleDataTypeAdd/MultipleDataTypeAdd.tsx:
##########
@@ -75,19 +77,32 @@ const MultipleDataTypeAdd = ({ onAdd, onCancel }:
MultipleDataTypeAddProps) => {
label="Data Types"
fieldId="data-types"
isRequired={true}
- validated={inputValidation}
- helperTextInvalid={"Please enter at least one Data Type Name"}
+ // validated={inputValidation}
+ // helperTextInvalid={"Please enter at least one Data Type Name"}
Review Comment:
```suggestion
```
##########
packages/pmml-editor/src/editor/components/Outputs/molecules/OutputFieldEditRow.tsx:
##########
@@ -154,9 +156,9 @@ const OutputFieldEditRow = (props: OutputFieldEditRowProps)
=> {
label="Name"
fieldId="output-name-helper"
isRequired={true}
- helperTextInvalid="Name is mandatory and must be unique"
- helperTextInvalidIcon={<ExclamationCircleIcon />}
- validated={name?.valid ? "default" : "error"}
+ // helperTextInvalid="Name is mandatory and must be unique"
+ // helperTextInvalidIcon={<ExclamationCircleIcon />}
+ // validated={name?.valid ? "default" : "error"}
Review Comment:
```suggestion
```
##########
packages/online-editor/src/authSessions/AuthSessionSelect.tsx:
##########
@@ -25,10 +25,10 @@ import {
SelectPosition,
SelectProps,
SelectVariant,
-} from "@patternfly/react-core/dist/js/components/Select";
+} from "@patternfly/react-core/deprecated";
import { AuthProviderIcon } from "../authProviders/AuthProviderIcon";
import { useAuthSession, useAuthSessions } from "./AuthSessionsContext";
-import { IconSize } from "@patternfly/react-icons/dist/js/createIcon";
+// import { IconSize } from "@patternfly/react-icons/dist/js/createIcon";
Review Comment:
```suggestion
```
##########
packages/pmml-editor/src/editor/components/DataDictionary/DataTypeItem/DataTypeItem.tsx:
##########
@@ -225,9 +222,9 @@ const DataTypeItem = (props: DataTypeItemProps) => {
<FormGroup
fieldId="name"
label="Name"
- helperTextInvalid="Name is mandatory and must be
unique"
- helperTextInvalidIcon={<ExclamationCircleIcon />}
- validated={validation}
+ // helperTextInvalid="Name is mandatory and must be
unique"
+ // helperTextInvalidIcon={<ExclamationCircleIcon />}
+ // validated={validation}
Review Comment:
```suggestion
```
##########
packages/online-editor/src/editor/Toolbar/GitIntegration/CreateGistOrSnippetModal.tsx:
##########
@@ -24,7 +24,7 @@ import { WorkspaceDescriptor } from
"@kie-tools-core/workspaces-git-fs/dist/work
import { useWorkspaces } from
"@kie-tools-core/workspaces-git-fs/dist/context/WorkspacesContext";
import { Form, FormAlert, FormGroup, FormHelperText } from
"@patternfly/react-core/dist/js/components/Form";
import { Radio } from "@patternfly/react-core/dist/js/components/Radio";
-import { CheckCircleIcon } from
"@patternfly/react-icons/dist/js/icons/check-circle-icon";
+
Review Comment:
Can we reintroduce the use of `CheckCircleIcon` and `ExclamationCircleIcon`?
##########
packages/online-editor/src/settings/CorsProxySettingsTab.tsx:
##########
@@ -20,11 +20,13 @@
import * as React from "react";
import { useCallback } from "react";
import { Form, FormGroup } from
"@patternfly/react-core/dist/js/components/Form";
-import { InputGroup } from
"@patternfly/react-core/dist/js/components/InputGroup";
+import { InputGroup, InputGroupItem } from
"@patternfly/react-core/dist/js/components/InputGroup";
import { TextInput } from
"@patternfly/react-core/dist/js/components/TextInput";
import { Page, PageSection } from
"@patternfly/react-core/dist/js/components/Page";
import { useEnv } from "../env/hooks/EnvContext";
import { Text, TextContent } from
"@patternfly/react-core/dist/js/components/Text";
+import { HelperText, HelperTextItem } from
"@patternfly/react-core/dist/js/components/HelperText";
+import { ValidatedOptions } from "@patternfly/react-core/dist/js/helpers";
Review Comment:
```suggestion
import { HelperText } from
"@patternfly/react-core/dist/js/components/HelperText";
```
##########
packages/pmml-editor/src/editor/components/Outputs/organisms/OutputFieldExtendedProperties.tsx:
##########
@@ -153,26 +155,29 @@ export const OutputFieldExtendedProperties = (props:
OutputFieldExtendedProperti
<FormGroup
label="optype"
fieldId="output-optype-helper"
- helperText="Indicates the admissible operations on the values."
+ // helperText="Indicates the admissible operations on the values."
Review Comment:
```suggestion
```
##########
packages/pmml-editor/src/editor/components/Outputs/organisms/OutputFieldExtendedProperties.tsx:
##########
@@ -196,39 +201,59 @@ export const OutputFieldExtendedProperties = (props:
OutputFieldExtendedProperti
<FormSelectOption value={option} key={index} label={option} />
))}
</FormSelect>
+ {validationsTargetField.length === 0 ? (
+ <FormHelperText>
+ <HelperText>
+ <HelperTextItem variant="default"></HelperTextItem>
+ </HelperText>
+ </FormHelperText>
+ ) : (
+ <FormHelperText>
+ <HelperText>
+ <HelperTextItem
variant="warning">{validationsTargetField[0].message}</HelperTextItem>
+ </HelperText>
+ </FormHelperText>
+ )}
</FormGroup>
<FormGroup
label="Feature"
fieldId="output-feature-helper"
- helperText="Specifies the value the output field takes from the
computed mining result."
+ // helperText="Specifies the value the output field takes from the
computed mining result."
Review Comment:
```suggestion
```
##########
packages/runtime-tools-swf-enveloped-components/src/workflowForm/envelope/components/WorkflowForm/WorkflowForm.tsx:
##########
@@ -111,9 +113,9 @@ const WorkflowForm: React.FC<WorkflowFormProps & OUIAProps>
= ({ workflowDefinit
label="Start Workflow Data"
isRequired
fieldId="workflowData"
- helperTextInvalid={!isValid && "The Workflow Data should have a
JSON format."}
- helperTextInvalidIcon={<ExclamationCircleIcon />}
- validated={!isValid ? ValidatedOptions.error :
ValidatedOptions.default}
+ // helperTextInvalid={!isValid && "The Workflow Data should have
a JSON format."}
+ // helperTextInvalidIcon={<ExclamationCircleIcon />} --> this
needs to be checked what has to be done for this icon
Review Comment:
I think you can try to follow the example here:
https://v5-archive.patternfly.org/components/forms/form/#invalid-with-form-alert
##########
packages/pmml-editor/src/editor/components/Outputs/organisms/OutputFieldExtendedProperties.tsx:
##########
@@ -273,27 +305,39 @@ export const OutputFieldExtendedProperties = (props:
OutputFieldExtendedProperti
aria-describedby="output-rank-helper"
autoComplete="off"
value={rank ?? ""}
- onChange={(e) => setRank(toNumber(e))}
+ onChange={(_event, e) => setRank(toNumber(e))}
onBlur={() =>
commit({
rank: rank,
})
}
isDisabled={value !== undefined && value.length > 0}
/>
+ <FormHelperText>
+ <HelperText>
+ <HelperTextItem variant="default">
+ Specifies the rank of the feature value from the mining result
that should be selected.
+ </HelperTextItem>
+ </HelperText>
+ </FormHelperText>
</FormGroup>
<FormGroup
label="Rank order"
fieldId="output-rankOrder-helper"
- helperText="Determines the sorting order when ranking the results."
+ // helperText="Determines the sorting order when ranking the results."
className="outputs-container__extended-properties__field"
>
{rankOrderEditor}
+ <FormHelperText>
+ <HelperText>
+ <HelperTextItem variant="default">Determines the sorting order
when ranking the results.</HelperTextItem>
+ </HelperText>
+ </FormHelperText>
</FormGroup>
<FormGroup
label="Segment Id"
fieldId="output-segmentId-helper"
- helperText="Provides an approach to deliver results from Segments."
+ // helperText="Provides an approach to deliver results from Segments."
Review Comment:
```suggestion
```
##########
packages/runtime-tools-swf-enveloped-components/src/cloudEventForm/envelope/components/CloudEventForm/CloudEventForm.tsx:
##########
@@ -21,13 +21,12 @@ import React, { useCallback, useEffect, useMemo, useRef,
useState } from "react"
import { componentOuiaProps, OUIAProps } from
"@kie-tools/runtime-tools-components/dist/ouiaTools";
import { CloudEventFormDefaultValues, CloudEventFormDriver } from
"../../../api";
import { ActionListGroup } from
"@patternfly/react-core/dist/js/components/ActionList";
-import { Select, SelectOption, SelectVariant } from
"@patternfly/react-core/dist/js/components/Select";
+import { Select, SelectOption, SelectVariant } from
"@patternfly/react-core/deprecated";
import { TextInput } from
"@patternfly/react-core/dist/js/components/TextInput";
import { Button } from "@patternfly/react-core/dist/js/components/Button";
import { Form, FormGroup } from
"@patternfly/react-core/dist/js/components/Form";
-import { InputGroup } from
"@patternfly/react-core/dist/js/components/InputGroup";
+import { InputGroup, InputGroupItem } from
"@patternfly/react-core/dist/js/components/InputGroup";
import { ValidatedOptions } from "@patternfly/react-core/dist/js/helpers";
-import ExclamationCircleIcon from
"@patternfly/react-icons/dist/esm/icons/exclamation-circle-icon";
Review Comment:
Can we bring back the use of ExclamationCircleIcon and remove the comments
in this file?
##########
packages/online-editor/src/settings/ExtendedServicesSettingsTab.tsx:
##########
@@ -73,43 +75,61 @@ export function ExtendedServicesSettingsTab() {
</FormAlert>
<FormGroup
isRequired={true}
- helperTextInvalid={""}
- validated={"default"}
+ // helperTextInvalid={""}
+ // validated={"default"}
label={"Host"}
fieldId={"host-input"}
>
<InputGroup>
- <TextInput
- id="host-input"
- name="host"
- aria-describedby="host-text-input-helper"
- placeholder={""}
- validated={"default"}
- value={host}
- onChange={setHost}
- autoFocus={true}
- />
+ <InputGroupItem isFill>
+ <TextInput
+ id="host-input"
+ name="host"
+ aria-describedby="host-text-input-helper"
+ placeholder={""}
+ validated={"default"}
+ value={host}
+ onChange={(_event, val) => setHost(val)}
+ autoFocus={true}
+ />
+ </InputGroupItem>
</InputGroup>
+ <HelperText>
+ {/* (
+ <HelperTextItem variant="default"
icon={ValidatedOptions.default}>
+ {""}
+ </HelperTextItem>
+ ) */}
+ </HelperText>
</FormGroup>
<FormGroup
isRequired={false}
- helperTextInvalid={""}
- validated={"default"}
+ // helperTextInvalid={""}
+ // validated={"default"}
label={"Port"}
fieldId={"port-input"}
>
<InputGroup>
- <TextInput
- id="port-input"
- name="port"
- aria-describedby="port-text-input-helper"
- placeholder={""}
- validated={"default"}
- value={port}
- onChange={setPort}
- autoFocus={true}
- />
+ <InputGroupItem isFill>
+ <TextInput
+ id="port-input"
+ name="port"
+ aria-describedby="port-text-input-helper"
+ placeholder={""}
+ validated={"default"}
+ value={port}
+ onChange={(_event, val) => setPort(val)}
+ autoFocus={true}
+ />
+ </InputGroupItem>
</InputGroup>
+ <HelperText>
+ {/* (
+ <HelperTextItem variant="default"
icon={ValidatedOptions.default}>
+ {""}
+ </HelperTextItem>
+ ) */}
Review Comment:
```suggestion
```
##########
packages/online-editor/src/settings/ExtendedServicesSettingsTab.tsx:
##########
@@ -73,43 +75,61 @@ export function ExtendedServicesSettingsTab() {
</FormAlert>
<FormGroup
isRequired={true}
- helperTextInvalid={""}
- validated={"default"}
+ // helperTextInvalid={""}
+ // validated={"default"}
label={"Host"}
fieldId={"host-input"}
>
<InputGroup>
- <TextInput
- id="host-input"
- name="host"
- aria-describedby="host-text-input-helper"
- placeholder={""}
- validated={"default"}
- value={host}
- onChange={setHost}
- autoFocus={true}
- />
+ <InputGroupItem isFill>
+ <TextInput
+ id="host-input"
+ name="host"
+ aria-describedby="host-text-input-helper"
+ placeholder={""}
+ validated={"default"}
+ value={host}
+ onChange={(_event, val) => setHost(val)}
+ autoFocus={true}
+ />
+ </InputGroupItem>
</InputGroup>
+ <HelperText>
+ {/* (
+ <HelperTextItem variant="default"
icon={ValidatedOptions.default}>
+ {""}
+ </HelperTextItem>
+ ) */}
Review Comment:
```suggestion
```
##########
packages/pmml-editor/src/editor/components/Outputs/organisms/OutputFieldExtendedProperties.tsx:
##########
@@ -303,21 +347,33 @@ export const OutputFieldExtendedProperties = (props:
OutputFieldExtendedProperti
aria-describedby="output-segmentId-helper"
autoComplete="off"
value={segmentId ?? ""}
- onChange={(e) => setSegmentId(e)}
+ onChange={(_event, e) => setSegmentId(e)}
onBlur={() =>
commit({
segmentId: segmentId,
})
}
/>
+ <FormHelperText>
+ <HelperText>
+ <HelperTextItem variant="default">Provides an approach to deliver
results from Segments.</HelperTextItem>
+ </HelperText>
+ </FormHelperText>
</FormGroup>
<FormGroup
label="Final result?"
fieldId="output-isFinalResult-helper"
- helperText="Should the field be returned to the user or is only used
as input."
+ // helperText="Should the field be returned to the user or is only
used as input."
Review Comment:
```suggestion
```
##########
packages/pmml-editor/src/editor/components/Outputs/organisms/OutputsBatchAdd.tsx:
##########
@@ -74,18 +76,31 @@ const OutputsBatchAdd = ({ onAdd, onCancel }:
OutputsBatchAddProps) => {
label="Outputs"
fieldId="outputs"
isRequired={true}
- validated={inputValidation}
- helperTextInvalid={"Please enter at least one Output name"}
+ // validated={inputValidation}
+ // helperTextInvalid={"Please enter at least one Output name"}
Review Comment:
```suggestion
```
##########
packages/pmml-editor/src/editor/components/Outputs/organisms/OutputFieldExtendedProperties.tsx:
##########
@@ -248,20 +273,27 @@ export const OutputFieldExtendedProperties = (props:
OutputFieldExtendedProperti
}
isDisabled={rank !== undefined}
/>
+ <FormHelperText>
+ <HelperText>
+ <HelperTextItem variant="default">
+ Used in conjunction with result features referring to specific
values.
+ </HelperTextItem>
+ </HelperText>
+ </FormHelperText>
</FormGroup>
<FormGroup
label="Rank"
fieldId="output-rank-helper"
- helperText="Specifies the rank of the feature value from the mining
result that should be selected."
+ // helperText="Specifies the rank of the feature value from the mining
result that should be selected."
Review Comment:
```suggestion
```
##########
packages/online-editor/src/settings/CorsProxySettingsTab.tsx:
##########
@@ -41,23 +43,32 @@ export function CorsProxySettingsTab() {
<Form onSubmit={onSubmit}>
<FormGroup
isRequired={true}
- helperTextInvalid={""}
- validated={"default"}
+ // helperTextInvalid={""}
+ // validated={"default"}
label={"URL"}
fieldId={"url-input"}
>
<InputGroup>
- <TextInput
- isDisabled={true}
- id="url-input"
- name="url"
- aria-describedby="url-text-input-helper"
- placeholder={""}
- validated={"default"}
- value={env.KIE_SANDBOX_CORS_PROXY_URL}
- autoFocus={true}
- />
+ <InputGroupItem isFill>
+ <TextInput
+ isDisabled={true}
+ id="url-input"
+ name="url"
+ aria-describedby="url-text-input-helper"
+ placeholder={""}
+ validated={"default"}
+ value={env.KIE_SANDBOX_CORS_PROXY_URL}
+ autoFocus={true}
+ />
+ </InputGroupItem>
</InputGroup>
+ <HelperText>
+ {/* (
+ <HelperTextItem variant="default"
icon={ValidatedOptions.default}>
+ {""}
+ </HelperTextItem>
+ ) */}
Review Comment:
```suggestion
```
##########
packages/online-editor/src/importFromUrl/ImportableUrlHooks.tsx:
##########
@@ -19,11 +19,11 @@
import { Button, ButtonVariant } from
"@patternfly/react-core/dist/js/components/Button";
import { FormHelperText } from
"@patternfly/react-core/dist/js/components/Form";
-import { Spinner } from "@patternfly/react-core/dist/js/components/Spinner";
+
Review Comment:
We should reintroduce the use of Spinner and CheckCircleIcon
##########
packages/online-editor/src/settings/CorsProxySettingsTab.tsx:
##########
@@ -41,23 +43,32 @@ export function CorsProxySettingsTab() {
<Form onSubmit={onSubmit}>
<FormGroup
isRequired={true}
- helperTextInvalid={""}
- validated={"default"}
+ // helperTextInvalid={""}
+ // validated={"default"}
Review Comment:
```suggestion
```
##########
packages/online-editor/src/settings/ExtendedServicesSettingsTab.tsx:
##########
@@ -73,43 +75,61 @@ export function ExtendedServicesSettingsTab() {
</FormAlert>
<FormGroup
isRequired={true}
- helperTextInvalid={""}
- validated={"default"}
+ // helperTextInvalid={""}
+ // validated={"default"}
Review Comment:
```suggestion
```
##########
packages/online-editor/src/extendedServices/ExtendedServicesModal.tsx:
##########
@@ -872,22 +868,31 @@ function ExtendedServicesPortForm() {
<FormGroup
fieldId={"extended-services-port"}
label={i18n.dmnRunner.modal.wizard.advancedSettings.label}
- validated={
- config.port === "" || parseInt(config.port, 10) < 0 ||
parseInt(config.port, 10) > 65353
- ? "error"
- : "success"
- }
-
helperTextInvalid={i18n.dmnRunner.modal.wizard.advancedSettings.helperTextInvalid}
+ // validated={
Review Comment:
Can you port this logic in the new version?
##########
packages/online-editor/src/importFromUrl/ImportableUrlHooks.tsx:
##########
@@ -19,11 +19,11 @@
import { Button, ButtonVariant } from
"@patternfly/react-core/dist/js/components/Button";
import { FormHelperText } from
"@patternfly/react-core/dist/js/components/Form";
-import { Spinner } from "@patternfly/react-core/dist/js/components/Spinner";
+
import { ValidatedOptions } from
"@patternfly/react-core/dist/js/helpers/constants";
import { Flex, FlexItem } from "@patternfly/react-core/dist/js/layouts/Flex";
-import { IconSize } from "@patternfly/react-icons/dist/js/createIcon";
-import CheckCircleIcon from
"@patternfly/react-icons/dist/js/icons/check-circle-icon";
+// import { IconSize } from "@patternfly/react-icons/dist/js/createIcon";
Review Comment:
```suggestion
```
##########
packages/online-editor/src/workspace/components/WorkspaceCommitModal.tsx:
##########
@@ -118,18 +119,27 @@ export const WorkspaceCommitModal:
PromiseModalChildren<string, WorkspaceCommitM
<Form onSubmit={onSubmit}>
<FormGroup
fieldId={"kie-sandbox-custom-commit-message"}
- validated={validation.result ? ValidatedOptions.success :
ValidatedOptions.error}
- helperTextInvalid={<CommitValidationErrorMessages
validations={validation.reasons} />}
+ // validated={validation.result ? ValidatedOptions.success :
ValidatedOptions.error}
+ // helperTextInvalid={<CommitValidationErrorMessages
validations={validation.reasons} />}
Review Comment:
```suggestion
```
##########
packages/pmml-editor/src/editor/components/EditorScorecard/molecules/CharacteristicsTableEditRow.tsx:
##########
@@ -208,9 +210,9 @@ export const CharacteristicsTableEditRow = (props:
CharacteristicsTableEditRowPr
label="Name"
isRequired={true}
fieldId="characteristic-form-name-helper"
- helperTextInvalid="Name is mandatory and must be unique"
- helperTextInvalidIcon={<ExclamationCircleIcon />}
- validated={name.valid ? "default" : "error"}
+ // helperTextInvalid="Name is mandatory and must be unique"
+ // helperTextInvalidIcon={<ExclamationCircleIcon />}
+ // validated={name.valid ? "default" : "error"}
Review Comment:
```suggestion
```
##########
packages/runtime-tools-process-enveloped-components/src/processList/envelope/components/ProcessListActionsKebab/ProcessListActionsKebab.tsx:
##########
@@ -17,7 +17,8 @@
* under the License.
*/
import React, { useCallback, useMemo, useState } from "react";
-import { Dropdown, DropdownItem, KebabToggle } from
"@patternfly/react-core/dist/js/components/Dropdown";
+// import { Dropdown, DropdownItem, KebabToggle } from
"@patternfly/react-core/dist/js/components/Dropdown";
Review Comment:
```suggestion
```
##########
packages/pmml-editor/src/editor/components/Outputs/organisms/OutputFieldExtendedProperties.tsx:
##########
@@ -273,27 +305,39 @@ export const OutputFieldExtendedProperties = (props:
OutputFieldExtendedProperti
aria-describedby="output-rank-helper"
autoComplete="off"
value={rank ?? ""}
- onChange={(e) => setRank(toNumber(e))}
+ onChange={(_event, e) => setRank(toNumber(e))}
onBlur={() =>
commit({
rank: rank,
})
}
isDisabled={value !== undefined && value.length > 0}
/>
+ <FormHelperText>
+ <HelperText>
+ <HelperTextItem variant="default">
+ Specifies the rank of the feature value from the mining result
that should be selected.
+ </HelperTextItem>
+ </HelperText>
+ </FormHelperText>
</FormGroup>
<FormGroup
label="Rank order"
fieldId="output-rankOrder-helper"
- helperText="Determines the sorting order when ranking the results."
+ // helperText="Determines the sorting order when ranking the results."
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
