fantonangeli commented on code in PR #2853: URL: https://github.com/apache/incubator-kie-tools/pull/2853#discussion_r2014467213
########## packages/runtime-tools-management-console-webapp/src/tasks/components/ImpersonationPageSection.tsx: ########## Review Comment: Can you please check why it is rendered differently compare to `main` branch? **Steps to reproduce:** - `cd packages/runtime-tools-management-console-webapp; pnpm start:all` - http://localhost:9025/ - "Connect to a runtime" - Alias: test - URL: http://localhost:8080/my-subpath - Check "Force login prompt" - Connect - User: admin Pwd:admin - Go to "Tasks" - Expand " Impersonate"   ########## packages/runtime-tools-management-console-webapp/src/authSessions/components/AuthSessionsList.tsx: ########## @@ -90,36 +83,45 @@ function AuthSessionCard({ onClick={onSelect} > <CardHeader + actions={{ + actions: ( + <> + {authSession.status === AuthSessionStatus.INVALID && ( + <Tooltip + content={"Could not authenticate using this session. Its Token was probably revoked, or expired."} + > + <ExclamationCircleIcon style={{ color: "var(--pf-v5-global--palette--red-100)" }} /> + </Tooltip> + )} + <Button + variant={ButtonVariant.link} + onClick={(e) => { + e.stopPropagation(); + return authSessionsDispatch.remove(authSession); + }} + > + Remove + </Button> + </> + ), + hasNoOffset: false, + className: undefined, + }} onExpand={(e) => { e.stopPropagation(); return setExpanded((prev) => !prev); }} > - <CardActions> - {authSession.status === AuthSessionStatus.INVALID && ( - <Tooltip content={"Could not authenticate using this session. Its Token was probably revoked, or expired."}> - <ExclamationCircleIcon style={{ color: "var(--pf-global--palette--red-100)" }} /> - </Tooltip> - )} - <Button - variant={ButtonVariant.link} - onClick={(e) => { - e.stopPropagation(); - return authSessionsDispatch.remove(authSession); - }} - > - Remove - </Button> - </CardActions> - <CardHeaderMain - style={{ display: "flex", opacity: authSession.status === AuthSessionStatus.INVALID ? 0.6 : 1 }} - > - <Flex alignItems={{ default: "alignItemsCenter" }} style={{ display: "inline-flex" }}> - <TextContent> - <Text component={TextVariants.h3}>{`${getAuthSessionDisplayInfo(authSession).userFriendlyName}`}</Text> - </TextContent> - </Flex> - </CardHeaderMain> + actions= Review Comment: Can you please check this file, I think there have been issues with codemod during the last merge.  ########## packages/scesim-editor/src/TestScenarioEditor.tsx: ########## @@ -35,13 +35,18 @@ import { SceSim__FactMappingType } from "@kie-tools/scesim-marshaller/dist/schem import { Alert } from "@patternfly/react-core/dist/js/components/Alert"; import { Bullseye } from "@patternfly/react-core/dist/js/layouts/Bullseye"; import { Drawer, DrawerContent, DrawerContentBody } from "@patternfly/react-core/dist/js/components/Drawer"; -import { EmptyState, EmptyStateBody, EmptyStateIcon } from "@patternfly/react-core/dist/js/components/EmptyState"; +import { + EmptyState, + EmptyStateBody, + EmptyStateIcon, + EmptyStateHeader, +} from "@patternfly/react-core/dist/js/components/EmptyState"; import { Flex } from "@patternfly/react-core/dist/js/layouts/Flex"; import { Icon } from "@patternfly/react-core/dist/js/components/Icon"; import { Spinner } from "@patternfly/react-core/dist/js/components/Spinner"; import { Tabs, Tab, TabTitleIcon, TabTitleText } from "@patternfly/react-core/dist/js/components/Tabs"; -import { Title } from "@patternfly/react-core/dist/js/components/Title"; +import {} from "@patternfly/react-core/dist/js/components/Title"; Review Comment: ```suggestion ``` ########## packages/online-editor/src/editor/Toolbar/GitIntegration/CreateGistOrSnippetModal.tsx: ########## @@ -330,6 +330,13 @@ If you are, it means that creating this Snippet failed and it can safely be dele description={i18n.createGistOrSnippetModal.form.visibility.private.description} onChange={() => setPrivate(true)} /> + {/* <FormHelperText> + <HelperText> + <HelperTextItem variant="error"> + <ExclamationCircleIcon />{" "} + </HelperTextItem> + </HelperText> + </FormHelperText> */} Review Comment: ```suggestion ``` ########## packages/runtime-tools-management-console-webapp/src/process/details/ProcessDetails.tsx: ########## @@ -32,9 +32,11 @@ import { EmptyStateBody, EmptyStateIcon, EmptyStateVariant, + EmptyStateHeader, + EmptyStateFooter, } from "@patternfly/react-core/dist/js/components/EmptyState"; import { SearchIcon } from "@patternfly/react-icons/dist/js/icons/search-icon"; -import { Title } from "@patternfly/react-core/dist/js/components/Title"; +import {} from "@patternfly/react-core/dist/js/components/Title"; Review Comment: ```suggestion ``` ########## packages/runtime-tools-management-console-webapp/src/authSessions/components/NewAuthSessionModal.tsx: ########## @@ -146,34 +147,49 @@ export const NewAuthSessionModal: React.FC<Props> = ({ onAddAuthSession }) => { id="alias" aria-label="Alias" autoFocus={true} - onChange={setAlias} + onChange={(_event, val) => setAlias(val)} placeholder="Enter an alias..." tabIndex={0} /> </FormGroup> - <FormGroup - label="URL" - isRequired={true} - helperTextInvalid={error} - helperText={" "} - validated={error ? "error" : "default"} - > - <TextInput id="url" aria-label="URL" tabIndex={0} onChange={setRuntimeUrl} placeholder="Enter a URL..." /> + <FormGroup label="URL" isRequired={true}> Review Comment: Can you please check why this page doesn't show the error when the URL is not valid? ########## packages/scesim-editor/src/drawer/TestScenarioDrawerDataSelectorPanel.tsx: ########## @@ -562,10 +567,12 @@ function TestScenarioDataSelectorPanel() { (treeViewEmptyStatus.visibility === "hidden" && ( <Bullseye> <EmptyState> - <EmptyStateIcon icon={treeViewEmptyStatus.icon} /> - <Title headingLevel="h4" size="lg"> - {treeViewEmptyStatus.title} - </Title> + <EmptyStateHeader icon={<EmptyStateIcon icon={treeViewEmptyStatus.icon} />} /> Review Comment: We have 2 `EmptyStateHeader` here, can you check? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
