fantonangeli commented on code in PR #2853:
URL:
https://github.com/apache/incubator-kie-tools/pull/2853#discussion_r2028846382
##########
packages/runtime-tools-management-console-webapp/src/tasks/components/ImpersonationPageSection.tsx:
##########
@@ -153,38 +155,33 @@ export const ImpersonationPageSection: React.FC<{}> = ()
=> {
/>
}
>
- <FormGroup label={"User"}>
+ <FormGroup label={"User"} style={{ maxWidth: "500px" }}>
<TextInput
- className={
- username && username === impersonationUsername
- ? "pf-c-form-control pf-m-success"
- : "pf-c-form-control pf-m-expanded"
- }
+ validated={username && username === impersonationUsername ?
"success" : "error"}
id="username"
aria-label="Username"
autoFocus={false}
placeholder={`None (currently as
'${authSessionInfo.username}')`}
tabIndex={1}
- style={{ maxWidth: "400px" }}
value={username ?? ""}
- onChange={setUsername}
+ onChange={(_event, val) => setUsername(val)}
/>
</FormGroup>
- <FormGroup label={"Groups"} helperText={"Comma-separated list, no
spaces."}>
+ <FormGroup label={"Groups"} style={{ maxWidth: "500px" }}>
<TextInput
- className={
- groups && groups === impersonationGroups
- ? "pf-c-form-control pf-m-success"
- : "pf-c-form-control pf-m-expanded"
- }
+ validated={groups && groups === impersonationGroups ?
"success" : "error"}
Review Comment:
```suggestion
validated={groups && groups === impersonationGroups ?
"success" : "default"}
```
##########
packages/runtime-tools-management-console-webapp/src/tasks/components/ImpersonationPageSection.tsx:
##########
@@ -153,38 +155,33 @@ export const ImpersonationPageSection: React.FC<{}> = ()
=> {
/>
}
>
- <FormGroup label={"User"}>
+ <FormGroup label={"User"} style={{ maxWidth: "500px" }}>
<TextInput
- className={
- username && username === impersonationUsername
- ? "pf-c-form-control pf-m-success"
- : "pf-c-form-control pf-m-expanded"
- }
+ validated={username && username === impersonationUsername ?
"success" : "error"}
Review Comment:
```suggestion
validated={username && username === impersonationUsername ?
"success" : "default"}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
