szha commented on a change in pull request #18921:
URL: https://github.com/apache/incubator-mxnet/pull/18921#discussion_r471824816
##########
File path: 3rdparty/mshadow/CMakeLists.txt
##########
@@ -59,6 +59,9 @@ endif()
if(USE_CUDNN)
target_compile_definitions(mshadow INTERFACE MSHADOW_USE_CUDNN)
endif()
+if(USE_CUTENSOR)
+ target_compile_definitions(mshadow INTERFACE MSHADOW_USE_CUTENSOR)
+endif()
Review comment:
there shouldn't be a licensing concern given that it's an optional
dependency
UPDATE:
if it wasn't clear, I'm addressing this comment specifically:
> Another topic is of course the whole licensing topic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
