marcoabreu commented on a change in pull request #18921:
URL: https://github.com/apache/incubator-mxnet/pull/18921#discussion_r479500460
##########
File path: 3rdparty/mshadow/CMakeLists.txt
##########
@@ -59,6 +59,9 @@ endif()
if(USE_CUDNN)
target_compile_definitions(mshadow INTERFACE MSHADOW_USE_CUDNN)
endif()
+if(USE_CUTENSOR)
+ target_compile_definitions(mshadow INTERFACE MSHADOW_USE_CUTENSOR)
+endif()
Review comment:
I agree that users should be able to choose, but I'm arguing that we
should rather do that at run time opposed to having every nitty gritty option
at compile time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
