marcoabreu commented on a change in pull request #18921:
URL: https://github.com/apache/incubator-mxnet/pull/18921#discussion_r479508094
##########
File path: 3rdparty/mshadow/CMakeLists.txt
##########
@@ -59,6 +59,9 @@ endif()
if(USE_CUDNN)
target_compile_definitions(mshadow INTERFACE MSHADOW_USE_CUDNN)
endif()
+if(USE_CUTENSOR)
+ target_compile_definitions(mshadow INTERFACE MSHADOW_USE_CUTENSOR)
+endif()
Review comment:
I know that the c++ world tends towards compile time options because
it's just so easy with all the preprocessor statements, but smart loading (e.g.
only when the appropriate dependencies and environment are present) and runtime
feature toggles are something that can even be done in the c++ world.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
