marcoabreu commented on a change in pull request #18921:
URL: https://github.com/apache/incubator-mxnet/pull/18921#discussion_r479507046
##########
File path: 3rdparty/mshadow/CMakeLists.txt
##########
@@ -59,6 +59,9 @@ endif()
if(USE_CUDNN)
target_compile_definitions(mshadow INTERFACE MSHADOW_USE_CUDNN)
endif()
+if(USE_CUTENSOR)
+ target_compile_definitions(mshadow INTERFACE MSHADOW_USE_CUTENSOR)
+endif()
Review comment:
Not all, but we have to start somewhere. We can't make every feature a
compile time option and then say that it's because it's generally not possible.
We should start small and incrementally get to that state.
Just this feature as example. We would need an entire different build plus a
few full test suite runs to test this particular flavour. And then when talk
about publishing, we either have to decide if we enable or disable it - the
other option will then get totally forgotten because not many people will
bother to compile with every single flag changed.
If we do it at runtime, we could have systems รก la autotuning which
determine the best flags (or allows the user to easily toggle), but if we don't
start somewhere, we will never get to that point.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
