maht commented on a change in pull request #437: Support to run NuttX on ESP32
QEMU
URL: https://github.com/apache/incubator-nuttx/pull/437#discussion_r388333738
##########
File path: tools/Makefile.unix
##########
@@ -501,6 +501,23 @@ ifeq ($(CONFIG_UBOOT_UIMAGE),y)
cp -f uImage /tftpboot/uImage; \
fi
endif
+ifeq ($(CONFIG_ESP32_BINARY),y)
+ @echo "MKIMAGE: ESP32 binary"
+ $(Q) if ! esptool.py version | grep "v2[.]"; then \
+ echo ""; \
+ echo "Please install ESP-IDF tools"; \
+ echo ""; \
+ echo "Check
https://docs.espressif.com/projects/esp-idf/en/v4.0/get-started/index.html#installation-step-by-step
or run the following command"; \
+ echo ""; \
+ echo "cd tools/esp32 && make && cd ../.."; \
+ echo ""; \
+ echo "run make again to create the nuttx.bin image."; \
+ else \
+ echo "Generating: $(NUTTXNAME).bin (ESP32 compatible)"; \
+ esptool.py --chip esp32 elf2image --flash_mode dio --flash_size
4MB -o nuttx.bin nuttx && \
+ echo "Generated: $(NUTTXNAME).bin (ESP32 compatible)"; \
+ fi
+endif
Review comment:
Thanks for the feedback. Yes, I figured out that this code was not good
enough to be ready to merge, that is the reason I wanted to work more on it
before uploading ... but some people requested some info about how to use QEMU,
and it was easier to just create the pull request to share and accelerate the
feedback loop. I will try to see if there is a way to move the code to proper
location.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
