patacongo commented on a change in pull request #437: Support to run NuttX on
ESP32 QEMU
URL: https://github.com/apache/incubator-nuttx/pull/437#discussion_r388415277
##########
File path: tools/Makefile.unix
##########
@@ -501,6 +501,23 @@ ifeq ($(CONFIG_UBOOT_UIMAGE),y)
cp -f uImage /tftpboot/uImage; \
fi
endif
+ifeq ($(CONFIG_ESP32_BINARY),y)
+ @echo "MKIMAGE: ESP32 binary"
+ $(Q) if ! esptool.py version | grep "v2[.]"; then \
Review comment:
I am thinking that a more systematic solution is needed both for CXD56xx and
ESP32 and for any future platforms that require custom binary generation after
the final linking step. I have started some more general discussion in #442
I am thinking that perhaps we should support some Makefiles and tools in
directories under tools/. Then perhaps we could do a wildcard check for:
(TOPDIR)/tools/$(CONFIG_ARCH)/Makefile
And if it exists, then run it. So in this case, it would check for
tools/esp32/Makefile and would execture tools/esp32/Makefile to generate the
binary using the changes in this PR.
This is more effort, but would serve the needs of all architectures,
existing and future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
