xiaoxiang781216 commented on a change in pull request #437: Support to run 
NuttX on ESP32 QEMU
URL: https://github.com/apache/incubator-nuttx/pull/437#discussion_r388336333
 
 

 ##########
 File path: tools/Makefile.unix
 ##########
 @@ -501,6 +501,23 @@ ifeq ($(CONFIG_UBOOT_UIMAGE),y)
                cp -f uImage /tftpboot/uImage; \
        fi
 endif
+ifeq ($(CONFIG_ESP32_BINARY),y)
+       @echo "MKIMAGE: ESP32 binary"
+       $(Q) if ! esptool.py version | grep "v2[.]"; then \
 
 Review comment:
   Could we let QEMU directly load ELF image instead binary? So we don't 
include the speicial version of gcc from silicon vendor.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to