maht commented on a change in pull request #437: Support to run NuttX on ESP32
QEMU
URL: https://github.com/apache/incubator-nuttx/pull/437#discussion_r388406435
##########
File path: tools/Makefile.unix
##########
@@ -501,6 +501,23 @@ ifeq ($(CONFIG_UBOOT_UIMAGE),y)
cp -f uImage /tftpboot/uImage; \
fi
endif
+ifeq ($(CONFIG_ESP32_BINARY),y)
+ @echo "MKIMAGE: ESP32 binary"
+ $(Q) if ! esptool.py version | grep "v2[.]"; then \
+ echo ""; \
+ echo "Please install ESP-IDF tools"; \
+ echo ""; \
+ echo "Check
https://docs.espressif.com/projects/esp-idf/en/v4.0/get-started/index.html#installation-step-by-step
or run the following command"; \
+ echo ""; \
+ echo "cd tools/esp32 && make && cd ../.."; \
+ echo ""; \
+ echo "run make again to create the nuttx.bin image."; \
+ else \
+ echo "Generating: $(NUTTXNAME).bin (ESP32 compatible)"; \
+ esptool.py --chip esp32 elf2image --flash_mode dio --flash_size
4MB -o nuttx.bin nuttx && \
+ echo "Generated: $(NUTTXNAME).bin (ESP32 compatible)"; \
+ fi
+endif
Review comment:
> I do have to fight on an almost daily basis to maintain good modularity in
the OS, but I feel like I am losing the battle. I am being overwhelmed by
self-serving, ill-conceived changes that keep the submitter from having do the
amount of work that is necessary to maintain the modularity.
Sorry to hear that, I don't wanted to cause trouble. But in my defense, if
something is not good in the first place, it generates a dilemma on new
additions: should we care more about consistency with existing practices (even
bad ones) or should we do the correct one despite that will create
inconsistencies. The ideal solution should migrate everything, but that puts a
burden on the people contributing that was not involved on the original bad
practice. So, I will suggest that we should identify that bad practices and at
least, if not fix them, mark them as bad _in the code_ (like some FIXME
commment). That way the new contributors could be more aware about the
preference of other merits over inconsistency in that particular case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
