maht commented on a change in pull request #437: Support to run NuttX on ESP32
QEMU
URL: https://github.com/apache/incubator-nuttx/pull/437#discussion_r388424886
##########
File path: tools/Makefile.unix
##########
@@ -501,6 +501,23 @@ ifeq ($(CONFIG_UBOOT_UIMAGE),y)
cp -f uImage /tftpboot/uImage; \
fi
endif
+ifeq ($(CONFIG_ESP32_BINARY),y)
+ @echo "MKIMAGE: ESP32 binary"
+ $(Q) if ! esptool.py version | grep "v2[.]"; then \
+ echo ""; \
+ echo "Please install ESP-IDF tools"; \
+ echo ""; \
+ echo "Check
https://docs.espressif.com/projects/esp-idf/en/v4.0/get-started/index.html#installation-step-by-step
or run the following command"; \
+ echo ""; \
+ echo "cd tools/esp32 && make && cd ../.."; \
+ echo ""; \
+ echo "run make again to create the nuttx.bin image."; \
+ else \
+ echo "Generating: $(NUTTXNAME).bin (ESP32 compatible)"; \
+ esptool.py --chip esp32 elf2image --flash_mode dio --flash_size
4MB -o nuttx.bin nuttx && \
+ echo "Generated: $(NUTTXNAME).bin (ESP32 compatible)"; \
+ fi
+endif
Review comment:
Ok, then try to move the other examples of bad practice of this case or at
least leave a message in the code if the efforts spans more than a week or so.
I think once there is no "bad example" on place, it would be easier to
anyone to point out what is accepted and what is not, so the human review
effort would be less, hopefully.
And by the way, from my part, thanks for being so strict :) It pays off on
the long term.
I will try to port some of the other cases if I have some time or contribute
as needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
