igrr commented on a change in pull request #437: Support to run NuttX on ESP32 
QEMU
URL: https://github.com/apache/incubator-nuttx/pull/437#discussion_r388416984
 
 

 ##########
 File path: tools/Makefile.unix
 ##########
 @@ -501,6 +501,23 @@ ifeq ($(CONFIG_UBOOT_UIMAGE),y)
                cp -f uImage /tftpboot/uImage; \
        fi
 endif
+ifeq ($(CONFIG_ESP32_BINARY),y)
+       @echo "MKIMAGE: ESP32 binary"
+       $(Q) if ! esptool.py version | grep "v2[.]"; then \
 
 Review comment:
   Loading an ELF file directly should be possible, provided that the ELF file 
includes the necessary CPU startup code and exception vectors. This doesn't 
happen when you build an ESP-IDF application — currently it always relies on 
the ROM code to provide the startup code and the exception vectors. However i 
think that NuttX includes such an option: 
https://github.com/apache/incubator-nuttx/blob/119a38ce10d8be96b8373b5a19145eda231edd93/boards/xtensa/esp32/esp32-core/README.txt#L491-L499
 (i haven't tried it myself).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to