tmedicci commented on code in PR #18195: URL: https://github.com/apache/nuttx/pull/18195#discussion_r2731731547
########## arch/xtensa/src/common/espressif/esp_loader.c: ########## @@ -50,6 +50,10 @@ # include "esp_rom_uart.h" # include "esp_rom_sys.h" # include "esp_app_format.h" +# ifndef CONFIG_ESPRESSIF_SIMPLE_BOOT_IMAGE_OFFSET +# define CONFIG_ESPRESSIF_SIMPLE_BOOT_IMAGE_OFFSET \ + CONFIG_BOOTLOADER_OFFSET_IN_FLASH +# endif Review Comment: Why is this change necessary? `CONFIG_BOOTLOADER_OFFSET_IN_FLASH` is a fixed value (it's the position the ROM bootloader will look for), so it shouldn't be changed at all... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
