Laczen commented on code in PR #18195: URL: https://github.com/apache/nuttx/pull/18195#discussion_r2732106377
########## arch/xtensa/src/common/espressif/esp_loader.c: ########## @@ -50,6 +50,10 @@ # include "esp_rom_uart.h" # include "esp_rom_sys.h" # include "esp_app_format.h" +# ifndef CONFIG_ESPRESSIF_SIMPLE_BOOT_IMAGE_OFFSET +# define CONFIG_ESPRESSIF_SIMPLE_BOOT_IMAGE_OFFSET \ + CONFIG_BOOTLOADER_OFFSET_IN_FLASH +# endif Review Comment: It is much simpler, it operates similar to mcuboot but is using the standard espressif image format. The ram part of the image contains sufficient information to setup the irom/drom mapping (which is mainly the image offset and some routines to setup the mappings and caches) similar to mcuboot and simpleboot. The bootloader just copies the iram and dram part (and possibly other ram items) and transfers control to the __start that is located in iram. As the standard espressif images irom and drom parts can be moved by esptool.py the same method as in simpleboot is used to restore the irom and drom start addresses. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
