almir-okato commented on PR #18195: URL: https://github.com/apache/nuttx/pull/18195#issuecomment-3811436663
> Hi @tmedicci thanks for your comments. > > I would like to keep both commits as the second commit will only be advantageous with the first commit. > > Regarding the first commit: as said this is just a image format. I don't understand the problem: if someone would like to generate a image with a different offset and try to boot it from the rom bootloader the boot fails. Likewise images images generated for a mcuboot bootloader that utilizes different slot definitions will fail. > > Regarding enabling the use (adding it to Kconfig) and documenting this will be a next step. Hi @Laczen, I agree with @tmedicci, it would be better organized and traceable if you wrap this new config with its Kconfig definition commit, related feature/example and documentation into a separated PR. By the way, I think your proposed idea is interesting, looking forward to see it implemented. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
