Laczen commented on code in PR #18195: URL: https://github.com/apache/nuttx/pull/18195#discussion_r2733453319
########## arch/xtensa/src/common/espressif/esp_loader.c: ########## @@ -50,6 +50,10 @@ # include "esp_rom_uart.h" # include "esp_rom_sys.h" # include "esp_app_format.h" +# ifndef CONFIG_ESPRESSIF_SIMPLE_BOOT_IMAGE_OFFSET +# define CONFIG_ESPRESSIF_SIMPLE_BOOT_IMAGE_OFFSET \ + CONFIG_BOOTLOADER_OFFSET_IN_FLASH +# endif Review Comment: @almir-okato yes, for a offset different from `CONFIG_BOOTLOADER_OFFSET_IN_FLASH` a 2nd stage bootloader is required to boot it. The proposed PR just creates a "new" kind of image format that can be used by a custom bootloader. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
