almir-okato commented on code in PR #18195: URL: https://github.com/apache/nuttx/pull/18195#discussion_r2732776034
########## arch/xtensa/src/common/espressif/esp_loader.c: ########## @@ -50,6 +50,10 @@ # include "esp_rom_uart.h" # include "esp_rom_sys.h" # include "esp_app_format.h" +# ifndef CONFIG_ESPRESSIF_SIMPLE_BOOT_IMAGE_OFFSET +# define CONFIG_ESPRESSIF_SIMPLE_BOOT_IMAGE_OFFSET \ + CONFIG_BOOTLOADER_OFFSET_IN_FLASH +# endif Review Comment: What I meant is that this image with a `CONFIG_ESPRESSIF_SIMPLE_BOOT_IMAGE_OFFSET` set differently from the default `CONFIG_BOOTLOADER_OFFSET_IN_FLASH` will not be "standalone directly bootable" as the current Simple boot image (single build image and bootable by ROM bootloader). So, if you define this different offset, you'll still need a minimum image bootable by ROM bootloader (IRAM/DRAM fixed positions) that will then map the segments from this offset, unless you tweak some more things I imagine. It seems that this may save some flash space as you said, but it would be good to document and specify how `CONFIG_ESPRESSIF_SIMPLE_BOOT_IMAGE_OFFSET` may be defined and implement eventual build system and additional code changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
