daniel-p-carvalho commented on code in PR #20148: URL: https://github.com/apache/nuttx/pull/20148#discussion_r4057422400
########## arch/arm/src/common/stm32/stm32_eth_m3m4_v1.c: ########## @@ -635,6 +635,13 @@ struct stm32_ethmac_s uint32_t rxtimelow; /* Received packet timestamp subsecond */ uint32_t rxtimehigh; /* Received packet timestamp seconds */ #endif +#ifdef CONFIG_STM32_ETH_TIMESTAMP_TX + struct iob_queue_s tx_tstampq; /* Pending TX timestamp loopback packets */ Review Comment: Done, the field is `txtstampq` now. ########## arch/arm/src/common/stm32/stm32_eth_m3m4_v1.c: ########## @@ -635,6 +635,13 @@ struct stm32_ethmac_s uint32_t rxtimelow; /* Received packet timestamp subsecond */ uint32_t rxtimehigh; /* Received packet timestamp seconds */ #endif +#ifdef CONFIG_STM32_ETH_TIMESTAMP_TX + struct iob_queue_s tx_tstampq; /* Pending TX timestamp loopback packets */ + + /* Per-descriptor TX clone */ + + struct iob_s *tx_meta[CONFIG_STM32_ETH_NTXDESC]; Review Comment: Done, the array is `txmeta` now. ########## arch/arm/src/common/stm32/stm32_eth_m3m4_v1.c: ########## @@ -709,6 +716,9 @@ static int stm32_recvframe(struct stm32_ethmac_s *priv); static void stm32_receive(struct stm32_ethmac_s *priv); static void stm32_freeframe(struct stm32_ethmac_s *priv); static void stm32_txdone(struct stm32_ethmac_s *priv); +#ifdef CONFIG_STM32_ETH_TIMESTAMP_TX +static void stm32_tx_tstamp_flush(struct stm32_ethmac_s *priv); Review Comment: Done, the function is `stm32_txtstamp_flush()` now. I also renamed the local `hw_time` to `hwtime` in `stm32_freeframe()` for the same reason, and updated the commit messages that mention these names. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
