casaroli commented on PR #20993: URL: https://github.com/apache/nuttx/pull/20993#issuecomment-6531098811
Open points before this can be approved: 1. The TC wait is still a loop count (timeout = 5000), shorter than the two characters that can still be in TDR and the shift register at low baud rates (details in the thread on stm32_serial_m33_v3.c). `tcsetattr()` with `TCSADRAIN` or `TCSAFLUSH` already drains the output before `TCSETS`. **Fix:** remove the TC wait in all six files, as #20914 did for L4. 2. The Impact section does not name all families that build the changed files (F1, F2, F4, L1, G4, L0, U3, C5). **Fix:** list all of them. 3. Testing has a build and the reference manuals only; CONTRIBUTING 1.7.2 asks for a runtime log from a real target. **Fix:** add a before/after log from one changed family, for example CR1 after tcsetattr() with 8E1. 4. d6157304f76 changes the code that 1fd310184c8 adds. **Fix:** squash it into 1fd310184c8. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
