xiangfu0 commented on code in PR #19795:
URL: https://github.com/apache/pinot/pull/19795#discussion_r4244620684
##########
pinot-core/src/test/java/org/apache/pinot/queries/SerializedBytesQueriesTest.java:
##########
@@ -276,7 +276,7 @@ public void testInnerSegmentAggregation()
// PercentileTDigest
TDigest tDigest = (TDigest) aggregationResult.get(4);
- TDigest expectedTDigest =
TDigest.createMergingDigest(PERCENTILE_TDIGEST_COMPRESSION);
+ TDigest expectedTDigest =
PercentileTDigestAccumulator.forLegacyAggregation(PERCENTILE_TDIGEST_COMPRESSION);
Review Comment:
Added independent accuracy guards in 5786d749d9: serialized
multi-segment/broker group-by now checks the median against the original
measurements, and the real star-tree path checks p75 against exact
PERCENTILE/PERCENTILEMV samples (SV and inherited MV). Both use a tie-safe 2%
rank bound. Existing ordinary group-by exact-percentile checks remain.
All 18 tests in the three affected query suites pass, along with scoped
precommit, zero-warning compilation, and independent Pinot review. In an
isolated fixed-seed sensitivity probe, shifting quantiles by -0.25 in both
expected/actual native paths passed the old paired comparisons but failed each
of the three new rank guards.
Only two test files changed (+35 lines). The remaining 536 tests and genuine
3.2/3.3 byte/270-case oracle evidence are reused with unchanged
production/build inputs; the preceding head also passed all 15 CI checks,
including the actual hosted legacy step. New-head CI is tracked separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
