xiangfu0 commented on PR #19795: URL: https://github.com/apache/pinot/pull/19795#issuecomment-6116231125
**[review] `PercentileSmartTDigestAggregationFunction.Parameters` (line ~400): `StringUtils.deleteWhitespace` return value is ignored, so parameter strings with spaces fail to parse.** `deleteWhitespace` returns the stripped string; calling it without assignment is a no-op, so `PERCENTILE_SMART_TDIGEST(col, 50, 'threshold = 10000; compression = 50')` fails with an invalid-parameter error because keys/values retain surrounding spaces. Pre-existing before this PR (the line sits outside the diff, hence a top-level comment), but trivially fixable while this file is being touched: ```java parametersString = StringUtils.deleteWhitespace(parametersString); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
