bxji commented on a change in pull request #4984: [TE] Fix over-scheduling tasks in data availability scheduler URL: https://github.com/apache/incubator-pinot/pull/4984#discussion_r366667013
########## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/anomaly/detection/trigger/DataAvailabilityTaskScheduler.java ########## @@ -80,7 +85,7 @@ public DataAvailabilityTaskScheduler(long delayInSec, long fallBackTimeInSec) { @Override public void run() { Map<DetectionConfigDTO, Set<String>> detection2DatasetMap = new HashMap<>(); - Map<String, Long> dataset2RefreshTimeMap = new HashMap<>(); + Map<String, Pair<Long, Long>> dataset2RefreshTimeMap = new HashMap<>(); Review comment: Using Pair<Long, Long> for <last refresh time, last refresh event time> may make the code a little hard to read without context. Would it be better to create a class for this instead? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org