jihaozh commented on a change in pull request #4984: [TE] Fix over-scheduling tasks in data availability scheduler URL: https://github.com/apache/incubator-pinot/pull/4984#discussion_r367039478
########## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/anomaly/detection/trigger/utils/DataAvailabilitySchedulingConfiguration.java ########## @@ -37,9 +37,11 @@ private List<String> dataSourceWhitelist; private List<String> filterClassList; // delay time after each run for the scheduler to reduce DB polling - private long schedulerDelayInSec = 300; // 5 minute + private long schedulerDelayInSec = 300; // 5 minutes // default threshold if detection level threshold is not set private long taskTriggerFallBackTimeInSec = 24 * 60 * 60; // 1 day + // scheduling window for data availability scheduling + private long schedulingWindowInSec = 15 * 60; // 15 minutes Review comment: Maybe it's better to use `TimeUnit.MINUTES.toSeconds(15)` than calculating seconds by multiplication. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
