jihaozh commented on a change in pull request #4984: [TE] Fix over-scheduling
tasks in data availability scheduler
URL: https://github.com/apache/incubator-pinot/pull/4984#discussion_r367039836
##########
File path:
thirdeye/thirdeye-pinot/src/test/java/org/apache/pinot/thirdeye/anomaly/detection/trigger/DataAvailabilityTaskSchedulerTest.java
##########
@@ -79,7 +79,7 @@ public void beforeMethod() {
metric1.setDerived(false);
metric2.setAlias("");
metricId2 = metricConfigManager.save(metric2);
- dataAvailabilityTaskScheduler = new DataAvailabilityTaskScheduler(60, 24 *
60 * 60);
+ dataAvailabilityTaskScheduler = new DataAvailabilityTaskScheduler(60, 24 *
60 * 60, 15 * 60);
Review comment:
Same as above, how about using `TimeUnit` class to convert to seconds?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
