xiaohui-sun commented on a change in pull request #4984: [TE] Fix
over-scheduling tasks in data availability scheduler
URL: https://github.com/apache/incubator-pinot/pull/4984#discussion_r367005162
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/anomaly/detection/trigger/DataAvailabilityTaskScheduler.java
##########
@@ -214,4 +224,11 @@ private boolean needFallback(DetectionConfigDTO
detectionConfig) throws Exceptio
long lastRunTime = taskLastCreateTimeMap.get(detectionConfigId);
return (System.currentTimeMillis() - lastRunTime >= notRunThreshold);
}
+
+ private boolean isWithinSchedulingWindow(Set<String> datasets, Map<String,
Pair<Long, Long>> dataset2RefreshTimeMap) {
+ long maxEventTime = datasets.stream()
+ .map(dataset -> dataset2RefreshTimeMap.get(dataset).getRight())
+ .reduce((v1, v2) -> (v1 > v2) ? v1 : v2).orElse(0L);
Review comment:
.max() should work
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
