sajjad-moradi commented on code in PR #9642: URL: https://github.com/apache/pinot/pull/9642#discussion_r1003888692
########## pinot-plugins/pinot-input-format/pinot-avro-base/src/main/java/org/apache/pinot/plugin/inputformat/avro/AvroRecordExtractorV2.java: ########## @@ -0,0 +1,36 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.plugin.inputformat.avro; + +import org.apache.avro.generic.GenericData; + + +/** + * Fixes the issue with extracting Avro's Fixed type. + */ +public class AvroRecordExtractorV2 extends AvroRecordExtractor { Review Comment: We can add a config for AvroRecordExtractor like `serialize_fixed_type` with default value of false. If the config is true, we use string representation, if false, we use byte[]. This way we can set the config for existing tables as true. For new tables, default value of false always uses byte[]. Having said that, I agree with you that most likely no one is using the string representation of Fixed types. Let me talk to my team tomorrow and I'll get back to you here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
