gviedma commented on code in PR #9642:
URL: https://github.com/apache/pinot/pull/9642#discussion_r1009552160
##########
pinot-spi/src/main/java/org/apache/pinot/spi/data/readers/BaseRecordExtractor.java:
##########
@@ -186,6 +187,9 @@ protected Object convertSingleValue(Object value) {
if (value instanceof Number || value instanceof byte[]) {
return value;
}
+ if (value instanceof GenericData.Fixed) {
Review Comment:
Nit: Why not check for the interface _GenericFixed_ instead? I think the
same logic would also apply for other implementations of GenericFixed, e.g.
[SpecificFixed](https://avro.apache.org/docs/1.8.1/api/java/org/apache/avro/specific/SpecificFixed.html).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
