Jackie-Jiang commented on code in PR #9642:
URL: https://github.com/apache/pinot/pull/9642#discussion_r1016616856
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/DataTypeTransformer.java:
##########
@@ -92,6 +92,13 @@ public GenericRow transform(GenericRow record) {
// Single-value column
source = PinotDataType.getSingleValueType(value.getClass());
}
+
+ if (source == PinotDataType.BYTES && dest == PinotDataType.STRING &&
value instanceof byte[]) {
Review Comment:
This will introduce more severe backward compatibility issue, where the
bytes values are expected to be converted using hex encoding. Let's not try to
handle this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
