KKcorps commented on code in PR #10376:
URL: https://github.com/apache/pinot/pull/10376#discussion_r1140044860
##########
pinot-common/src/main/java/org/apache/pinot/common/request/context/RequestContextUtils.java:
##########
@@ -230,6 +231,9 @@ private static String getStringValue(Expression
thriftExpression) {
throw new BadQueryRequestException(
"Pinot does not support column or function on the right-hand side of
the predicate");
}
+ if (thriftExpression.getLiteral().getSetField() ==
Literal._Fields.NULL_VALUE) {
+ return String.valueOf(null);
Review Comment:
We can avoid branching here and simply return "null"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
