61yao commented on code in PR #10376:
URL: https://github.com/apache/pinot/pull/10376#discussion_r1148152249
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/request/RequestUtils.java:
##########
@@ -173,7 +175,16 @@ public static Expression getLiteralExpression(byte[]
value) {
return expression;
}
+ public static Expression getUnknownLiteralExpression() {
Review Comment:
done
##########
pinot-common/src/main/java/org/apache/pinot/sql/parsers/rewriter/CompileTimeFunctionsInvoker.java:
##########
@@ -74,7 +75,12 @@ protected static Expression
invokeCompileTimeFunctionExpression(@Nullable Expres
if (functionInfo != null) {
Object[] arguments = new Object[numOperands];
for (int i = 0; i < numOperands; i++) {
- arguments[i] =
function.getOperands().get(i).getLiteral().getFieldValue();
+ Literal literal = function.getOperands().get(i).getLiteral();
+ if (literal.getSetField() == Literal._Fields.NULL_VALUE) {
Review Comment:
done
##########
pinot-core/src/test/java/org/apache/pinot/core/common/datatable/DataTableSerDeTest.java:
##########
@@ -614,6 +614,9 @@ private void fillDataTableWithRandomData(DataTableBuilder
dataTableBuilder,
OBJECTS[rowId] = isNull ? null : RANDOM.nextDouble();
dataTableBuilder.setColumn(colId, OBJECTS[rowId]);
break;
+ case UNKNOWN:
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
