gortiz commented on code in PR #10376:
URL: https://github.com/apache/pinot/pull/10376#discussion_r1143152828
##########
pinot-spi/src/main/java/org/apache/pinot/spi/data/FieldSpec.java:
##########
@@ -393,6 +393,7 @@ public enum DataType {
BOOLEAN(INT, false, true),
TIMESTAMP(LONG, false, true),
STRING(false, true),
+ UNKNOWN(false, true),
Review Comment:
There are like one thousand places where FieldSpec.DataType, which is
specially problematic in switch. Here the datatype I proposed in
https://github.com/apache/pinot/pull/10361 may be useful, but we decided to
drop it.
Have you checked the impact of this new literal in these switch? Or do you
plan to do that in another PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
