gortiz commented on code in PR #10376:
URL: https://github.com/apache/pinot/pull/10376#discussion_r1144686173
##########
pinot-spi/src/main/java/org/apache/pinot/spi/data/FieldSpec.java:
##########
@@ -393,6 +393,7 @@ public enum DataType {
BOOLEAN(INT, false, true),
TIMESTAMP(LONG, false, true),
STRING(false, true),
+ UNKNOWN(false, true),
Review Comment:
My point is that this PR does add `UNKNOWN` literal into
`FieldSpec.DataType`, but doesn't changes any of the places where
`FieldSpec.DataType` was used. This is specially important on switches. If they
include a `default` case, the new literal will fall on that case, which will
usually throw exceptions. In case of `switch`s without default case it can even
be worse.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
