61yao commented on code in PR #10376:
URL: https://github.com/apache/pinot/pull/10376#discussion_r1148152314
##########
pinot-core/src/test/java/org/apache/pinot/core/common/datatable/DataTableSerDeTest.java:
##########
@@ -743,6 +746,10 @@ private void verifyDataIsSame(DataTable newDataTable,
DataSchema.ColumnDataType[
Assert.assertEquals(ObjectSerDeUtils.deserialize(customObject),
OBJECTS[rowId], ERROR_MESSAGE);
}
break;
+ case UNKNOWN:
Review Comment:
done
##########
pinot-core/src/test/java/org/apache/pinot/core/common/datatable/DataTableSerDeTest.java:
##########
@@ -743,6 +746,10 @@ private void verifyDataIsSame(DataTable newDataTable,
DataSchema.ColumnDataType[
Assert.assertEquals(ObjectSerDeUtils.deserialize(customObject),
OBJECTS[rowId], ERROR_MESSAGE);
}
break;
+ case UNKNOWN:
+ Object nulValue = newDataTable.getCustomObject(rowId, colId);
+ Assert.assertNull(nulValue, ERROR_MESSAGE);
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
