61yao commented on code in PR #10604:
URL: https://github.com/apache/pinot/pull/10604#discussion_r1167254855
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/InTransformFunction.java:
##########
@@ -365,11 +380,56 @@ public int[] transformToIntValuesSV(ValueBlock
valueBlock) {
}
}
break;
+ case UNKNOWN:
+ break;
default:
throw new IllegalStateException();
}
}
return _intValuesSV;
}
+
Review Comment:
Performance matters more here than DRY. :)
Overriding transformToInValuesSVWithNull will avoid calling the base
function's transformToInValuesSVWithNull and you can call
_mainFunction.transformToInValuesSVWithNull to get the values and null bit map
at the same time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
