shenyu0127 commented on code in PR #10604:
URL: https://github.com/apache/pinot/pull/10604#discussion_r1172093471


##########
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/InTransformFunction.java:
##########
@@ -199,6 +210,8 @@ public int[] transformToIntValuesSV(ValueBlock valueBlock) {
               }
             }
             break;
+          case UNKNOWN:
+            break;

Review Comment:
   We don't have the problem of inconsistent results.
   
   We can enable/disable null in two places:
   - Data ingestion/storage 
   - Query option 
   
   If we disable null in data ingestion/storage, there is no inconsistency 
problem in the results between null enabled and disabled in the query option. 
If we enable null in data ingestion/storage, we should only allow the null 
enabled query option. 
   
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to