61yao commented on code in PR #10604:
URL: https://github.com/apache/pinot/pull/10604#discussion_r1174175796
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/InTransformFunction.java:
##########
@@ -365,11 +380,56 @@ public int[] transformToIntValuesSV(ValueBlock
valueBlock) {
}
}
break;
+ case UNKNOWN:
+ break;
default:
throw new IllegalStateException();
}
}
return _intValuesSV;
}
+
Review Comment:
The problem without implementing transformToXXWithNull is that we cannot
fill in the default values for all nulls.
For example, if the value is later evaluated null in getNullBitmap call, the
intValue field is not updated.
I think it is fine now because filling default value rule is not strictly
followed in default implementation. We can change this later when default
implementation is fixed.
Do you mind putting a TODO or a comment noting that the value for null is
undefined/indeterministic if the transformToInt API is called?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
