shenyu0127 commented on code in PR #10604:
URL: https://github.com/apache/pinot/pull/10604#discussion_r1171958095
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/InTransformFunction.java:
##########
@@ -199,6 +210,8 @@ public int[] transformToIntValuesSV(ValueBlock valueBlock) {
}
}
break;
+ case UNKNOWN:
+ break;
Review Comment:
If the value is null, we don't care about the values in _intValuesSV so we
don't need to set the values.
So we want to keep here as is and remove the code elsewhere that sets the
default null value in _intValuesSV
([e.g.](https://github.com/apache/pinot/blob/60ee5eb0e8a2cf8276565ae8b20fb81292315843/pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/BaseTransformFunction.java#L173))
and the related unit tests
([e.g.](https://github.com/apache/pinot/blob/d50f9ee8b04f615abc57eab4c08a53ad4902f72a/pinot-core/src/test/java/org/apache/pinot/core/operator/transform/function/ScalarTransformFunctionWrapperTest.java#L883))?
I'd be happy to do the cleanup in a different PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
